Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polygon clipping: d3.geoPolyhedral() now uses d3-geo-polygon if the plugin is available #132

Closed
wants to merge 7 commits into from
Closed

Polygon clipping: d3.geoPolyhedral() now uses d3-geo-polygon if the plugin is available #132

wants to merge 7 commits into from

Commits on Feb 20, 2018

  1. d3.geoPolyhedral() now uses d3-geo-polygon if the plugin is available. 

    Note that d3-geo-polygon is still unstable. When we stream points that belong to the clipping polygon itself, it sometimes bleeds out -- for example on the Waterman projection with a default aspect -- rotate [0,0]).

I have been as conservative as possible: d3-geo-projection works as usual without d3-geo-polygon, and checks that it has projection.preclip (d3-geo > 1.8.1).

Examples and issues at [d3-geo-polygon](https://github.com/d3/d3-geo-polygon)

Solves #129
Solves #124
Solves d3/d3-geo#108
Solves #86
    @Fil
    Fil committed Feb 20, 2018
    Configuration menu
    Copy the full SHA
    918dd88 View commit details
    Browse the repository at this point in the history

  2. close the clipping polygon (solves the 'equator problem' where a line… 

    … would not interesect the polygon and its visibility would be inverted)
    @Fil
    Fil committed Feb 20, 2018
    Configuration menu
    Copy the full SHA
    ea17033 View commit details
    Browse the repository at this point in the history

  3. equator issue is fixed, no need for antimeridian clipping

    @Fil
    Fil committed Feb 20, 2018
    Configuration menu
    Copy the full SHA
    b87da03 View commit details
    Browse the repository at this point in the history

  4. with d3-geo-polygon in place, the 3 polyhedral projections result in … 

    …images that are slightly (but not visibly) different
    @Fil
    Fil committed Feb 20, 2018
    Configuration menu
    Copy the full SHA
    aacee5a View commit details
    Browse the repository at this point in the history

  5. upgrade to d3-geo 1.9 and minor version bump to 2.4.0

    @Fil
    Fil committed Feb 20, 2018
    Configuration menu
    Copy the full SHA
    3866f30 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2018

  1. simplification (which again changes the output pngs for polyhedralXXX… 

    … in an invisible way)
    @Fil
    Fil committed Feb 22, 2018
    Configuration menu
    Copy the full SHA
    196f990 View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2018

  1. final (hopefully) version of the butterfly polyhedral, based on deter… 

    …ministic d3-geo-polygon (cf. d3/d3-geo-polygon@9513bb8)
    @Fil
    Fil committed Feb 24, 2018
    Configuration menu
    Copy the full SHA
    d073d4a View commit details
    Browse the repository at this point in the history