Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

d3.geoIntersectArc? #160

Closed
Fil opened this issue Mar 16, 2019 · 3 comments
Closed

d3.geoIntersectArc? #160

Fil opened this issue Mar 16, 2019 · 3 comments

Comments

@Fil
Copy link
Member

Fil commented Mar 16, 2019

Expose https://observablehq.com/@fil/spherical-intersection in d3-geo ?

It is available internally at https://github.com/d3/d3-geo-polygon/blob/master/src/intersect.js

Probably as d3.geoIntersectArc([[x1, y1], [x2, y2]], [[x3, y3], [x4, y4]]).
Or maybe d3.geoIntersectArc([x1, y1], [x2, y2], [x3, y3], [x4, y4])

would be useful for eg https://observablehq.com/@d3/graticule-labels-stereographic
Fil added a commit to d3/d3-geo-polygon that referenced this issue Mar 16, 2019
@Fil
geoIntersectArc + lots of test cases and bug fixes in the Spherical i…
d130e92 
…ntersection function.

Solves d3/d3-geo#160
@Fil
Copy link
Member Author

Fil commented Mar 16, 2019

The intersectArc branch at d3-geo-polygon exposes d3.geoIntersectArc([[x1, y1], [x2, y2]], [[x3, y3], [x4, y4]]). No problem to move it to d3-geo once we're sure it's stabilized.

@Fil Fil mentioned this issue Mar 16, 2019
Closed
Fil added a commit to d3/d3-geo-polygon that referenced this issue Mar 17, 2019
@Fil
geoIntersectArc + lots of test cases and bug fixes in the Spherical i…
eb1e663 
…ntersection function.

Solves d3/d3-geo#160
@Fil
Copy link
Member Author

Fil commented Mar 17, 2019

Released in d3-geo-polygon https://github.com/d3/d3-geo-polygon/releases/tag/v1.8.0

Do we want it in d3-geo too?

@Fil
Copy link
Member Author

Fil commented Jun 11, 2019

no

@Fil Fil closed this as completed Jun 11, 2019
@Fil Fil mentioned this issue May 28, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Fil