-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Graticule errors under gnomonic projection. #54
Comments
Yep. This is almost certainly a bug in clipping because the points on the graticule exactly fall on the clip circle. It goes away if you change the clip angle to 60.0001°, for example. FYI, I probably won’t be able to fix this bug and #55 anytime soon, since it would require a much deeper understanding of Jason’s geographic clipping code than I currently have. |
In Either Note that, when I log the value of
|
My understanding of the code is that this test on The test can be replaced instead by: The test was introduced in d3/d3@d93f45e . Side note: there is an utf8 |
Amazingly I couldn't reproduce this bug anymore on any newer browser (Firefox, Safari Chrome). However, launching an old copy of "Brave.app" that hadn't updated, the bug was reproducible. Fixed by #91 |
I've encountered some buggy behavior using the gnomonic projection with customized graticule steps. In some cases, there is incorrect line clipping. In others, an error is thrown. The issues arose when using a custom graticule step of
[15, 15]
. Removing the custom step or adjusting the projection clipAngle can make the issues to go away.Below is an example that replicates the errors in d3 v4.2.1 and Chrome 51.0.2704.103 (Mac OS). The example assumes
world-50m.json
is on the relative path. Also, see comments below for more.The text was updated successfully, but these errors were encountered: