Geo graticule #17
Merged
Geo graticule #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yeah, I just use that inside the getter/setter accessor functions so as to avoid coming up with two names for the property. So, inside component.foo, the private internal var is |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Note: Now that some of the common structure has been laid out, I've published 4 orthogonal branches. These can be reviewed and merged in any order, whenever you see fit. There might be slight merge conflicts around index.js, but that should be all.)
This branch addresses Issue #5,
d3.geoGraticule. I made sure to perform the renames that were mentioned in the README.One question about syntax: Many of the functions in this component have an argument named
_. Is this part of a naming convention you're using inside D3?