default geoCircle precision to 2 degrees #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Results in 180 control points instead of 60 (⨉3). The error is quadratic with the precision, with the worst case (for a parallel) being at latitude 45°. Under this new setting, the maximum error is now ~484m, vs. 4.365km with precision 6°. https://observablehq.com/@d3/geocircle-error
mbostock
approved these changes
Apr 28, 2023
Fil
added a commit
that referenced
this pull request
Apr 28, 2023
following #281 (note that for clipCircle the precision is not modifiable by the user) Manually rechecked each of the tests that are (slightly) modified as a consequence
Fil
added a commit
to d3/d3
that referenced
this pull request
Nov 20, 2023
for when we merge d3/d3-geo#281
|
linked documentation PR d3/d3#3803 |
mbostock
added a commit
to d3/d3
that referenced
this pull request
Mar 12, 2024
for when we merge d3/d3-geo#281 Co-authored-by: Mike Bostock <mbostock@gmail.com>
mbostock
added a commit
that referenced
this pull request
Mar 12, 2024
* default geoCircle precision to 2 degrees Results in 180 control points instead of 60 (⨉3). The error is quadratic with the precision, with the worst case (for a parallel) being at latitude 45°. Under this new setting, the maximum error is now ~484m, vs. 4.365km with precision 6°. https://observablehq.com/@d3/geocircle-error * document * refine clipCircle precision, from 6 degrees to 2 degrees following #281 (note that for clipCircle the precision is not modifiable by the user) Manually rechecked each of the tests that are (slightly) modified as a consequence --------- Co-authored-by: Mike Bostock <mbostock@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Results in 180 control points instead of 60 (⨉3). The error is quadratic with the precision, with the worst case (for a parallel) being at latitude 45°. Under this new setting, the maximum error is now ~484m, vs. 4.365km with precision 6°.
https://observablehq.com/@d3/geocircle-error