Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should internal nodes have (self) values? #9

Closed
mbostock opened this issue Oct 21, 2015 · 2 comments
Closed

Should internal nodes have (self) values? #9

mbostock opened this issue Oct 21, 2015 · 2 comments

Comments

@mbostock
Copy link
Member

Related #7. It’s possible to do this with a dummy node, but I’m not sure that’s a good idea. Does it really make sense for internal nodes to have value in a pack layout? There’s typically a lot of wasted space due to the enclosing circle having greater area than the sum of all children, so it’s not clear that visualizing this internal node value would be meaningful.
This was referenced Oct 21, 2015
Closed
Closed
@mbostock
Copy link
Member Author

Related d3/d3#2379, which proposes a hierarchy.parentValue accessor. I might rename that hierarchy.internalValue (if I were to add this feature)?

@mbostock mbostock mentioned this issue Oct 21, 2015
Closed
@mbostock mbostock mentioned this issue Nov 12, 2015
Closed
4 tasks
@mbostock mbostock changed the title Pack layout (or all hierarchy layouts?) should allow internal nodes to have value? Should internal nodes have (self) values? Nov 12, 2015
@mbostock
Copy link
Member Author

Fixed in #14.

@mbostock mbostock mentioned this issue Mar 3, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mbostock