Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite the treemap layout. #14

Merged
merged 72 commits into from Mar 22, 2016
Merged

Rewrite the treemap layout. #14

merged 72 commits into from Mar 22, 2016

Conversation

mbostock
Copy link
Member

@mbostock mbostock commented Nov 3, 2015

I don’t think we need to worry about overflow and underflow if we compute the
layout first without rounding, and then carefully round the resulting values.
The v3 implementation is complicated because it tries to round incrementally.
Since we don’t modify rect.
I still need to implement asymmetric padding, and decide whether to retain the
old treemap.padding property now that there are two types of padding.
@mbostock mbostock merged commit fddac40 into master Mar 22, 2016
@mbostock mbostock deleted the fix-treemap branch March 22, 2016 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant