New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite the treemap layout. #14
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbostock
force-pushed
the
fix-treemap
branch
from
November 12, 2015 01:43
cb1ad9b
to
6847612
Compare
Since we don’t modify rect.
I still need to implement asymmetric padding, and decide whether to retain the old treemap.padding property now that there are two types of padding.
This was referenced Mar 16, 2016
If the front chain only has three circles, don’t try to remove any more! Related d3/d3#1761.
Better fix for 57e90ce. Related d3/d3#1761.
Only parent nodes need names, so all leaf nodes to be anonymous. This is particularly convenient for flat (trivial) hierarchies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
area
andz
properties on nodes (Treemap shouldn’t populate area and z properties on nodes? #10).