padding in pack layout applies to both parent and siblings #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| levels[i].forEach(function(d) { | ||
| if (d.children && d.children.length > 0) { | ||
| d.children.forEach(function(e) { e.r += dr; }); | ||
| d3_layout_packSiblings(d); |
There was a problem hiding this comment.
I think you want to say packChildren here.
larskotthoff
force-pushed
the
pack.padding
branch
from
9c4a4d5
to
f00d165
Compare
|
Fixed the function call, thanks for pointing that out. Serves me right for just copying over the diff. |
|
I need to think through whether this is the optimal solution. I feel like it should be simpler (like, just modifying the radius after computing the enclosing circle), but I understand that it gets complicated because of how the padding is scaled. Right now I’m working through a massive backlog of issues, but I should get back to working on this repository in the near future. |
|
Also see d3/d3#2473. |
|
I’ve implemented parent-child padding in the new pack layout; pack.padding now applies both to sibling-sibling and parent-child relationships. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #7.