Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pretest error on windows #13

Closed
wants to merge 7 commits into from

Conversation

p-v-d-Veeken
Copy link

Okay, so the entire scripts section of package.json is just one big clusterf--- on Windows.

First the test script failed because Windows can't into embedded quotes, I fixed it by creating a separate script which gets called from the pretest command. Then, the test script failed, because dark powers are forming and we are powerless to stop Them, I fixed that error by just typing into the terminal and seeing what stuck. Then the prepublish script failed and I decided I had enough for today.

So yeah, this PR will get you halfway through the scripts section of package.json on Windows. I will see what I can do with the prepublish script, but once again, no promises.

@svanschooten
Copy link

Please incorporate this in your next versions. Tests can not bet run on windows. 👍

@mbostock
Copy link
Member

Some problems with this PR:

  • Removing the -p breaks the mkdir command on OS X and Linux.
  • Unintended removal of the eslint command.
  • Unnecessary change to .gitignore.

I’ll submit a separate fix shortly.

@mbostock mbostock closed this in 11a8974 Mar 14, 2016
@mbostock
Copy link
Member

This change needs to be propagated to ~30 other D3 modules. Please let me know if it works, and then I’ll go ahead and re-apply this commit to the other modules. Thanks.

@p-v-d-Veeken
Copy link
Author

@mbostock It doesn't work properly yet, see: #15

@mbostock
Copy link
Member

Yep, I’m on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants