Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Selection groups should be copy-on-write. #58

Closed
2 tasks done
mbostock opened this issue Feb 4, 2016 · 1 comment
Closed
2 tasks done

Selection groups should be copy-on-write. #58

mbostock opened this issue Feb 4, 2016 · 1 comment
Assignees
@mbostock

Comments

@mbostock
Copy link
Member

mbostock commented Feb 4, 2016

That way, derived transitions don’t need to make preemptive copies. There are only two places where groups are modified:

  • selection.data
  • selection.sort
@mbostock mbostock self-assigned this Feb 4, 2016
mbostock added a commit that referenced this issue Feb 11, 2016
@mbostock
Copy-on-write for selection.sort.
39a60e1 
Related #58.
@mbostock
Copy link
Member Author

Fixed in 0.6.10.

mbostock added a commit to d3/d3-transition that referenced this issue Feb 11, 2016
@mbostock
Avoid copy during selection.transition.
cf42062 
Since selection groups are now copy-on-write (d3/d3-selection#58), there’s no
need to make a copy when deriving the transition from a selection!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mbostock mbostock

Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mbostock