Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Single Key Negative stackOffsetDiverging Issue #115

Closed
wants to merge 1 commit into from
Closed

Single Key Negative stackOffsetDiverging Issue #115

wants to merge 1 commit into from

Conversation

hannahsquier
Copy link
Contributor

@hannahsquier hannahsquier commented Jan 29, 2018 •
edited
Loading

This change fixes the issue I outlined here #114

I ran the test suite, and all the tests pass.

1..587
# tests 587
# pass  587

# ok

@hannahsquier hannahsquier changed the title change series length check from 1 to 0 Single Key Negative stackOffsetDiverging Issue Jan 29, 2018
@hannahsquier hannahsquier mentioned this pull request Jan 29, 2018
Closed
@asherkin
Copy link

I can confirm that this change fixed the issue in a project I'm working on 👍 - many thanks!

@sdzaveri sdzaveri mentioned this pull request Mar 18, 2019
Closed
@pausebreak
Copy link

Hello,

We ran into this issue again. Is there something this PR lacks for acceptance? Willing to help!

@mbostock
Copy link
Member

Merged in 93e7e26.

@mbostock mbostock closed this Mar 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hannahsquier @asherkin @pausebreak @mbostock