New symbol "ecks" (x). #151
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarrettmeyer
commented
Oct 23, 2019
jarrettmeyer
commented
- Adds ecks.js, which draws an X symbol.
- Adds ecks to symbol.js.
- Adds symbolEcks export to index.js.
- Adds supporting unit tests.
* Adds ecks.js, which draws an X symbol. * Adds ecks to symbol.js. * Adds symbolEcks export to index.js. * Adds supporting unit tests.
|
I built your branch (d3-shape.js), and integrated it in https://observablehq.com/@fil/drag-symbols — but it didn't change much. I then realized that ecks is the same symbol as cross, only with a 45° rotation. So, is it really needed?
|
|
I agree with @Fil and think this is too similar to the existing cross symbol. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.