Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README update to avoid confusion with “Date” #200

Merged
merged 1 commit into from Jul 29, 2022
Merged

README update to avoid confusion with “Date” #200

merged 1 commit into from Jul 29, 2022

Conversation

hashboard-charlie
Copy link
Contributor

When I was reading through the stacking documentation, I stumbled over myself for an embarrassing amount of time, because it's very easy to misread "Dates" (the fruit) as "Date" (a time). This table also includes a "Month" column containing Date values, which led me to misunderstanding what stack.keys did.

This is obviously a minor thing - and caused by my own misreading of the text - but I do feel like it's a reasonable mistake to make while skimming docs. I felt like we could probably prevent this misunderstanding from happening to anybody else with a simple change.

Copy link
Member

@mbostock mbostock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍐🍐

@Fil Fil merged commit c95704e into d3:main Jul 29, 2022
@hashboard-charlie hashboard-charlie deleted the patch-1 branch July 29, 2022 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants