Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix android zoom bug #224

Closed
wants to merge 1 commit into from
Closed

Fix android zoom bug #224

wants to merge 1 commit into from

Conversation

souljorje
Copy link

Fixes #175, #195, #172

@Fil
Copy link
Member

Fil commented Oct 23, 2020

Thanks! The situation would be clearer if we had a test case somewhere, an a page with the fixed code. I've been trying to reproduce the problem and see if this fixed it, but still no success.

@Fil
Copy link
Member

Fil commented Oct 23, 2020

I see some sort of bug on (my daughter's phone) Android with this block : after zooming the page (natively), the chart is frozen (the d3 zoom doesn't work).

However this bug also happens with the patched version of d3-zoom @ this fixed block.

@souljorje
Copy link
Author

souljorje commented Oct 24, 2020

@Fil yeah, doublechecked, seems like problem is not in this, but still it saves us from unnecessary errors, like here uikit/uikit#3853.
I got different problem on OnePlus in Chrome: pinch zoomes whole page with map, and after few zoom and drag tries whole page freezes. And yeah, this patch doesn't help.
I tried to roll back to d3-zoom@1 and d3-selection@1, later my coworker will tell test and tell if it helped.

What is model of your daughter's phone?

@souljorje souljorje closed this Oct 24, 2020
@Fil
Copy link
Member

Fil commented Oct 24, 2020

Huawei P Smart; Android 10.0.0

@souljorje
Copy link
Author

souljorje commented Oct 25, 2020

@Fil, I've found solution for my issue: #172 (comment), it's not related to this PR, but anyway it's better to merge this PR to avoid errors rain in Android console. Could you reopen this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Zoom not working in android
2 participants