Defer first tick to end of timer frame. #1576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than interleave the initialization of transition tweens with their first tick, defer the first tick to the end of the current timer frame such that any DOM modifications that happen during the first tick do not trigger a forced relayout when another tween is initialized (e.g., getComputedStyle).
|
This fixes the issue in my app, though I'm not qualified to say if it's good otherwise. Thanks! |
Previously it was using Date.now(), which might be a millisecond or two past the now time of the current frame, and thus might not run until the next frame! By using the current time, we guarantee that it runs at the end of this frame.
mbostock
added a commit
that referenced
this pull request
Nov 13, 2015
This fixes a priority inversion where a transition B that is scheduled on transition A’s start initializes its tweens before transition A has its first tick. By scheduling transition A’s first tick before dispatching A’s start event, it’s first tick is guaranteed to run before any new transition’s tweens are initialized. Related #1576 d3/d3-transition#16.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than interleave the initialization of transition tweens with their first tick, defer the first tick to the end of the current timer frame such that any DOM modifications that happen during the first tick do not trigger a forced relayout when another tween is initialized (e.g., getComputedStyle).