Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pointer events for the drag behavior. #1799

Closed
wants to merge 2 commits into from

Conversation

mbostock
Copy link
Member

No description provided.

@natevw
Copy link
Contributor

natevw commented Apr 14, 2015

Any particular feedback why this was "iceboxed"? I need to review more fully — and figure out whether this patch still applies cleanly — but it's looking like a feature in an app I maintain may have relied on some of these fixes (and of course for IE support) after I switched to a different custom-patched D3 build that neglected this work. Ideally it would all just be in trunk at some point if possible.

@mbostock
Copy link
Member Author

Lack of time, at the moment.

@natevw
Copy link
Contributor

natevw commented Apr 22, 2015

xref as I pick this back up: http://bl.ocks.org/mbostock/9631744 is the nice little playground used for trying out d3.drag tweaks last round.

@natevw
Copy link
Contributor

natevw commented Apr 22, 2015

This patch definitely does not rebase cleanly, and most of its multitouch-related fixes were applied separately in the meantime.

I've re-done the Win8 (i.e. Pointer Events) work as #2403@mbostock perhaps you could close this and review that instead?

@mbostock mbostock added bug Something isn’t working ms labels Oct 21, 2015
@mbostock mbostock changed the title Fix drag touchend win8 Pointer events for the drag behavior. Dec 3, 2015
@mbostock
Copy link
Member Author

mbostock commented Dec 3, 2015

Related #2556.

@mbostock
Copy link
Member Author

mbostock commented Dec 3, 2015

Superseded by #2403.

@mbostock mbostock closed this Dec 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn’t working
Development

Successfully merging this pull request may close these issues.

None yet

2 participants