layout/force: handle case of zero weight on both linked nodes #2091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this case treat both nodes as having an equal weight of 1 (arbitrary). This fixes a divide by zero error otherwise. Signed-off-by: Alon Levy <alon@pobox.com>
|
This fix doesn’t handle the case where only one of s or t has a zero weight (it treats the zero weight as one), but that’s easy enough to fix. 😁 |
|
Merged into #2591 for 3.5.7. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this case treat both nodes as having an equal weight of 1
(arbitrary).
This fixes a divide by zero error otherwise.
I've included a signed-off (saying that I'm the author of the code). I didn't sign the contributor agreement since this falls under the trivial rule. Correct me if I am mistaken.