New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zoom behavior: clip scale to scaleExtent #2128

Closed

mgold wants to merge 1 commit into d3:master from mgold:clip-zoom-scale

Contributor

mgold commented Nov 25, 2014

Currently, it is possible to manually set a scale value outside a zoom behavior's scaleExtent.

var zoom = d3.behavior.zoom();
zoom.scaleExtent();
 > [0, Infinity]
zoom.scale(-1);
zoom.scale();
> -1
zoom.scaleExtent();
> [0, Infinity]

This seems broken to me. If you disagree, fine, close the PR. There's already a clipping function scaleTo so we just call that.


          Clip scale to scaleExtent

8b37735

mbostock added the bug label

mbostock modified the milestones: 3.5.x, 3.5.7

Member

mbostock commented Nov 2, 2015

Merged into #2591 for 3.5.7.

mbostock closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment