transition.remove() fix #2377
Closed
transition.remove() fix #2377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting. That sounds correct. I should think a bit about whether this is an alternative solution but your approach seems reasonable. |
transition.remove() ought to work even when a delayed transition was preempted by the current transition.
robinhouston
force-pushed
the
transition-remove-fix
branch
from
ac8bd3c
to
4345972
Compare
|
This is related to d3/d3-timer#5 (and d3/d3-transition#9, #2189), in that if we greedily canceled transitions—rather than waiting for them to self-terminate on start—then the count check would be safe. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We at Kiln recently noticed that calling
.remove()on a transition would not always work as expected (though explicitly removing the element from an.each("end", …)handler did work).It turns out that it wasn’t working in the situation where the running transition had preempted a transition that had not yet started (due to a delay).
This patch (with test) seems to resolve the problem, though you may have a better idea for how to deal with it. In any case it seems to me that the
this[ns].count < 2check is too simplistic, since there may be transitions with ids less than the active one, that will therefore never run.