Skip to content
This repository has been archived by the owner on Jul 22, 2020. It is now read-only.

Did this project just die? #7

Open
Miserlou opened this issue Feb 11, 2016 · 16 comments
Open

Did this project just die? #7

Miserlou opened this issue Feb 11, 2016 · 16 comments

Comments

@Miserlou
Copy link

Just saw your most recent commit.

Is this project now dead? Are there any working pure-Python PGSQL Django backends out there?

@d33tah
Copy link
Owner

d33tah commented Feb 11, 2016

@Miserlou:

Well I cannot promise I'll be maintaining it any time soon and I wasn't confident in its security, so I was torn between killing it or just saying with big letters in the README that this is experimental and you should put extra care when using it, ideally staying away from it on production. My worries are mostly about the way that query parameters are passed - I hadn't looked into PostgreSQL protocol implementation, but it's weird to me that escaping is done on the Python end instead of passing the placeholder values separately. An opinion from a core PostgreSQL developer would make me trust this code a bit more.

Though on the other hand I can already see three people interested in it (you and two PR authors), so perhaps there might be more options if there's interest. Let me know what you think about it, perhaps we could look for other solutions.

@d33tah
Copy link
Owner

d33tah commented Feb 11, 2016

Ping @stevepeak and @seanjensengrey. I'd like to hear your opinion as well.

@Miserlou
Copy link
Author

Ahhhhh, I see!

Well, we have a sudden need for a pure Python Django-PGSQL adapter because of this: Miserlou/django-zappa#3 - so I would very much like to see this project succeed.

I bet a core PostgresSQL developer could be roped into doing an audit of this code if you asked nicely? Most times developers love seeing downstream support of their projects. (I personally err on the side of something-is-better-than-nothing, nothing is ever 100% secure, and that more eyes make all bugs look shallow.)

Have you reached out to the PG core team yet?

@d33tah
Copy link
Owner

d33tah commented Feb 11, 2016

Have you reached out to the PG core team yet?

I hadn't. Could you?

@Miserlou
Copy link
Author

Okay, I have sent a message to the PG-Hackers list asking for help. Hopefully somebody will step up.

@d33tah
Copy link
Owner

d33tah commented Feb 11, 2016

👍 Awesome, thank you @Miserlou :) That's really appreciated.

@Miserlou
Copy link
Author

No problem at all, thanks for your work on bpgsql! Hope we can use it in Zappa.

@Miserlou
Copy link
Author

It actually looks like the original author is now alive and active on GitHub.. perhaps he would be interested in this discussion as well? Or would that be rude..

@d33tah
Copy link
Owner

d33tah commented Feb 11, 2016

Nah, I guess it's okay to call him here. @barryp

@barryp
Copy link

barryp commented Feb 11, 2016

I'm around, but not really doing anything with this project. It meet some needs I had back in the day, but I've moved on to other stuff. It uses an older version of the pgsql protocol - a complete rewrite is probably in order.

@d33tah
Copy link
Owner

d33tah commented Feb 12, 2016

@Miserlou: based on the traffic of the mailing list, I would guess it's quite unlikely we would get any responses. Any more ideas where we could get the review?

@Miserlou
Copy link
Author

Hm. Not sure what to do now, that wasn't the reaction I was hoping for.

Maybe we could try a subreddit or HN?

@d33tah
Copy link
Owner

d33tah commented Feb 15, 2016

@Miserlou: good ideas! Would you do that?

@seanjensengrey
Copy link
Contributor

@d33tah @Miserlou Radioing in. I have a couple flights in the near term. I'll read the code on the plane. My interest was having a pgsql driver for alt VMs like PyPy and Jython w/o having to shim out lib on each platform.

@Miserlou
Copy link
Author

Excellent! Thanks Sean!

On Mon, Feb 15, 2016 at 2:28 PM, Sean Jensen-Grey notifications@github.com
wrote:

@d33tah https://github.com/d33tah @Miserlou
https://github.com/Miserlou Radioing in. I have a couple flights in the
near term. I'll read the code on the plane. My interest was having a pgsql
driver for alt VMs like PyPy and Jython w/o having to shim out lib on each
platform.


Reply to this email directly or view it on GitHub
#7 (comment).

@d33tah
Copy link
Owner

d33tah commented Feb 20, 2016

@seanjensengrey: ping.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants