Skip to content

Commit

Permalink
Merge pull request #32 from d3b-center/no-updates
Browse files Browse the repository at this point in the history
馃悰 Don't stop looking if an old PR gets updated
  • Loading branch information
fiendish committed Jul 14, 2020
2 parents 702ced6 + 70f3b29 commit 95c7570
Showing 1 changed file with 7 additions and 4 deletions.
11 changes: 7 additions & 4 deletions d3b_release_maker/release_maker.py
Expand Up @@ -159,11 +159,14 @@ def _get_merged_prs(self, after, prs_to_ignore=None):
prs = []
prs_to_ignore = prs_to_ignore or {}
for p in self.session.yield_paginated(endpoint, query_params):
if p["merged_at"]:
if p["merged_at"] < after:
if p["merged_at"]: # only the merged PRs
if p["updated_at"] < after:
# stop looking if last update was before the last release
break
elif (p["number"] not in prs_to_ignore) and (
regex.search(release_pattern, p["title"]) is None
elif (
(p["merged_at"] > after) # ignore old PRs with updates
and (p["number"] not in prs_to_ignore)
and (regex.search(release_pattern, p["title"]) is None)
):
prs.append(p)
return prs
Expand Down

0 comments on commit 95c7570

Please sign in to comment.