Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Set default repo from git #23

Merged
merged 1 commit into from Jul 2, 2020
Merged

✨ Set default repo from git #23

merged 1 commit into from Jul 2, 2020

Conversation

dankolbman
Copy link
Contributor

Sets the default repo url by extracting the origin's url from the current git repository.

@dankolbman dankolbman added the feature New feature or request label Jul 1, 2020
@dankolbman dankolbman requested a review from fiendish July 1, 2020 18:41
@dankolbman dankolbman self-assigned this Jul 1, 2020
Copy link
Contributor

@fiendish fiendish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this errors if not in a git repo

@fiendish
Copy link
Contributor

fiendish commented Jul 2, 2020

Can you trap the exception from check_output or run the git remote call with check=False?

Copy link
Contributor

@fiendish fiendish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! I also routed stderr to devnull to quiet the error message

@fiendish fiendish merged commit aae22a3 into master Jul 2, 2020
@fiendish fiendish deleted the default-repo branch July 2, 2020 21:06
fiendish added a commit that referenced this pull request Jul 8, 2020
## Release 1.3.0

### Summary

- Emojis: ✨ x2
- Categories: Additions x2

### New features and changes

- [#23](#23) - ✨ Set default repo from git - [aae22a3](aae22a3) by [dankolbman](https://github.com/dankolbman)
- [#22](#22) - ✨ Add github token to script step env - [63b8a7d](63b8a7d) by [fiendish](https://github.com/fiendish)
@fiendish fiendish mentioned this pull request Jul 8, 2020
fiendish added a commit that referenced this pull request Jul 8, 2020
## Release 1.3.0

### Summary

- Emojis: ✨ x3
- Categories: Additions x3

### New features and changes

- [#26](#26) - ✨ Warn and give second chance if missing GH_TOKEN - [5835c1d](5835c1d) by [fiendish](https://github.com/fiendish)
- [#23](#23) - ✨ Set default repo from git - [aae22a3](aae22a3) by [dankolbman](https://github.com/dankolbman)
- [#22](#22) - ✨ Add github token to script step env - [63b8a7d](63b8a7d) by [fiendish](https://github.com/fiendish)
@fiendish fiendish mentioned this pull request Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants