Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

defined does not work for line series #1194

Closed
ColinEberhardt opened this issue Sep 13, 2018 · 0 comments · Fixed by #1195
Closed

defined does not work for line series #1194

ColinEberhardt opened this issue Sep 13, 2018 · 0 comments · Fixed by #1195
Labels
bug d3fc-series

Comments

@ColinEberhardt
Copy link
Member

The defined function is passed to the d3-shape line component at the point the line series is constructed:

https://github.com/d3fc/d3fc/blob/master/packages/d3fc-series/src/svg/line.js#L12

This means that the defined setter has no effect, i.e. the given function is not invoked:

fc.line().defined(d => false)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug d3fc-series
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ensure line / area series support defined ColinEberhardt/d3fc
1 participant
@ColinEberhardt