Skip to content
This repository has been archived by the owner on Jan 25, 2023. It is now read-only.

Commit

Permalink
removes unnecessary nested namespaces from Select appends
Browse files Browse the repository at this point in the history
  • Loading branch information
davelandry committed Feb 28, 2017
1 parent e2285bb commit 0928a5d
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/Select.js
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ export default class Select extends BaseClass {
.merge(container);

let select = container.selectAll(`select#d3plus-Select-${this._uuid}`).data([0]);
select = select.enter().append(svg ? "xhtml:select" : "select")
select = select.enter().append("select")
.attr("id", `d3plus-Select-${this._uuid}`)
.attr("class", "d3plus-Select")
.merge(select)
Expand Down Expand Up @@ -93,7 +93,7 @@ export default class Select extends BaseClass {
const label = container.selectAll(`label#d3plus-Label-${this._uuid}`)
.data(this._label ? [0] : []);
label.exit().remove();
label.enter().insert(svg ? "xhtml:label" : "label", `#d3plus-Select-${this._uuid}`)
label.enter().insert("label", `#d3plus-Select-${this._uuid}`)
.attr("id", `d3plus-Label-${this._uuid}`)
.attr("class", "d3plus-Label")
.attr("for", `d3plus-Select-${this._uuid}`)
Expand Down

0 comments on commit 0928a5d

Please sign in to comment.