Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uniform color scale legend not matching data? #78

Open
jspeis opened this issue May 30, 2019 · 1 comment
Open

uniform color scale legend not matching data? #78

jspeis opened this issue May 30, 2019 · 1 comment

Comments

@jspeis
Copy link

jspeis commented May 30, 2019

(not sure if this belongs elsewhere but figured I would start here)

Current Behavior

Screen Shot 2019-05-30 at 12 09 26 PM

In reviewing some vizs for CNY I noticed an issue where certain vizs seems to have black/very dark areas that don't seem to match up with the legend colors?

Steps to Reproduce (for bugs)

  1. https://jsfiddle.net/jonathan_dw/adrwsz3f/

Your Environment

  • Browser Name: Chrome
  • Operating System and Version: macOS 10.13
@davelandry
Copy link
Member

@jspeis oooo this is actually an interesting one! Ok so, the logic for determining the range of the color is based on the entire array of flat data, but when drawing the visualization it will group data points (and sum values) based on the specified group by. In this case, you have multiple years of data that are getting aggregated in the map! If you add time: "Year" to your config, it all looks right: https://jsfiddle.net/ebfvs78h/

My feeling is that... this may be user error and not a bug? Not sure how to catch for this internally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants