Fix null pointer in RandomIPGossip

d3scomp · Nov 3, 2014 · 4f228b3 · 4f228b3
1 parent 03ea4cb
commit 4f228b3
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/jdeeco-core/src/cz/cuni/mff/d3s/deeco/network/RandomIPGossip.java b/jdeeco-core/src/cz/cuni/mff/d3s/deeco/network/RandomIPGossip.java
@@ -23,16 +23,14 @@ public Collection<String> getRecipients(KnowledgeData data,
 		List<String> result = new LinkedList<>();
 
 		// Guard for no recipients
-		if (recipientSelectors != null && !recipientSelectors.isEmpty())
+		if (recipientSelectors == null)
 			return result;
 
 		// Add recipients from all selectors
-		for (DirectRecipientSelector selector: recipientSelectors) {
+		for (DirectRecipientSelector selector: recipientSelectors)
 			result.addAll(selector.getRecipients(data, sender));
-		}
 
-		// filter the owner of the data
-		// remove all
+		// Filter the owner of the data, remove all
 		while (result.remove(data.getMetaData().componentId));
 
 		return directGossipStrategy.filterRecipients(result);