Skip to content

Commit

Permalink
Some suggestions for the KnowledgeManagersView class.
Browse files Browse the repository at this point in the history
  • Loading branch information
bures committed Nov 3, 2013
1 parent 51c116d commit 7689113
Showing 1 changed file with 9 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,14 @@

import cz.cuni.mff.d3s.deeco.model.runtime.api.Trigger;

// FIXME TB: Any idea of some better name of the class? I would say this name is rather misleading.

// FIXME TB: Rewrite the Javadoc comment to the class. At this point it's a bit misleading. In particular:
// - "user" ???
// - "triggers of the others" ???
// - It should clearly say that this allows obtaining the shadow replicas and that it allows registering for
// changes in all shadow replicas (even in the future ones)

/**
* This interface allows the user to get the KnowledgeManagers and register/unregister
* the triggers of the others.
Expand All @@ -16,6 +24,7 @@ public interface KnowledgeManagersView {
public Collection<ReadOnlyKnowledgeManager> getOthersKnowledgeManagers();
// Rima : It is a little bit confusing to have the same name
// register/unregister as in KnowledgeManager.
// TB@RA: Good point. However, I can't come up with any better name. Any suggestions?
public void register(Trigger trigger, TriggerListener triggerListener);
public void unregister(Trigger trigger, TriggerListener triggerListener);

Expand Down

0 comments on commit 7689113

Please sign in to comment.