-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused checks #31
Comments
@RicoHeat Regarding adding these to Easylist or Easyprivacy. No. Adding domains that aren't actually used seems to be pointless. The benchmark should always be checking valid domains used on websites. Until these invalid domains are removed, just avoid this "benchmark". |
Yes @RicoHeat , the changes will be included in V3 directly as stable . Still working on it since i want to make it almost perfect ! I think everyone will love it even more than current |
Domains removed on upcoming version 3.0.0 of toolz |
Just a review of the current toolz checks. When adding domains, are there example sites being used to reference against each check? Seems pointless adding a domain check if it's never used outside of https://d3ward.github.io/toolz/adblock.html
A few checks aren't actually used for tracking, people may link to these Twitter pages for example, but they're not tracking or ads.
https://an.facebook.com/
shows no sites using it for tracking, no network blocksNon-existent:
ads-dev.pinterest.com
-> https://publicwww.com/websites/%22ads-dev.pinterest.com%22/d.reddit.com
-> https://publicwww.com/websites/%22d.reddit.com%22/hotjar-analytics.com
-> https://publicwww.com/websites/%22hotjar-analytics.com%22/api-hotjar.com
-> https://publicwww.com/websites/%22api-hotjar.com%22/amazonclix.com
-> https://publicwww.com/websites/%22amazonclix.com%22/amazonaax.com
-> https://publicwww.com/websites/%22amazonaax.com%22/advertising-api-eu.amazon.com
-> https://publicwww.com/websites/%22advertising-api-eu.amazon.com%22/affiliationjs.s3.amazonaws.com
-> https://publicwww.com/websites/%22affiliationjs.s3.amazonaws.com%22/analyticsengine.s3.amazonaws.com
-> https://publicwww.com/websites/%22analyticsengine.s3.amazonaws.com%22/The actual domain for
fastclick.com
isfastclick.net
, fastclick.com isn't a legit ads/tracking domain. Checking the .net is all is needed.The text was updated successfully, but these errors were encountered: