Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃敡 do not pre-fetch all resources for sample app #5

Merged
merged 7 commits into from
Apr 1, 2021

Conversation

Burtchen
Copy link
Contributor

So the issue with the sample app (see #4) fetching all resources at once during the build... is actually a feature, as

@vue-cli uses a webpack config for progressive web apps that prefetches all resources (source)

This PR fixes that, along with some minor markup cleanup. Once it's merged we could actually deploy the sample app via netlify!

Copy link
Contributor

@chaeringer chaeringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃殌 thanks for this update!

@Burtchen Burtchen merged commit 961f204 into main Apr 1, 2021
@Burtchen Burtchen deleted the burtchen/dynamic-loading-sample-app branch April 1, 2021 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants