Added ability to ignore fields by tagging them. #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added code and tests to support tagging fields with testdiff:"ignore". Adding this tag to any field will make messagediff skip this field. This is useful for transient fields that do not store actual value of the struct. I have used generic 'testdiff' tag to potentially make it usable by other libraries who might want to do the same purpose.
d4l3k
requested changes
Jul 14, 2017
README.md
Outdated
| a := someStruct{1, 2, []int{1}} | ||
| b := someStruct{1, 3, []int{1, 2}} | ||
| a := someStruct{1, 2, []int{1}, 9} | ||
| b := someStruct{1, 3, []int{1, 2}, 10} |
There was a problem hiding this comment.
Probably should add as a separate example to show off this feature since most people won't care about it.
There was a problem hiding this comment.
Do you mean to create a new test case, or to create a new Test with it's own struct?
There was a problem hiding this comment.
OK, I separated the test for ignoring fields into a separate test altogether.
|
I mistakenly thought your review comment related to actual tests and not README... I fixed it in docs now. I also corrected indentation of the code in README. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added code and tests to support tagging fields with testdiff:"ignore".
Adding this tag to any field will make messagediff skip this field.
This is useful for transient fields that do not store actual value of
the struct. I have used generic 'testdiff' tag to potentially make it
usable by other libraries who might want to do the same purpose.