Make sure path is not incorrectly modified via ref #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d4l3k
requested changes
Dec 13, 2016
There was a problem hiding this comment.
Thanks for catching this!
Could you also fix the failing test? Looks like we're testing for the incorrect behavior.
https://github.com/d4l3k/messagediff/blob/master/example/atom_test.go#L16
| d.Modified[&path] = bVal.Interface() | ||
| localPath := make(Path, len(path)) | ||
| copy(localPath, path) | ||
| d.Modified[&localPath] = bVal.Interface() |
There was a problem hiding this comment.
Instead of just copying in that one specific location, would be good to move it to the top of the diff function. That way it fixes all cases of that.
localPath := make(Path, len(path))
copy(localPath, path)
path = localPathNear https://github.com/d4l3k/messagediff/pull/8/files#diff-2aea0ca6be2f84668b7aefadf8f8ac26R44.
There was a problem hiding this comment.
Yup makes sense. Will fixup.
|
Tests updated and feedback addressed :) |
d4l3k
approved these changes
Dec 20, 2016
|
Thanks for fixing that! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes, the path name would be incorrectly listed as the last path processed. This makes sure the path is not updated via the
pathpointer.