Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Config File #8

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Add Config File #8

wants to merge 11 commits into from

Conversation

d4rckh
Copy link
Owner

@d4rckh d4rckh commented May 10, 2021

as requested in #7

src/vaf.nim Show resolved Hide resolved
It contains:
- VersionNumber (string)
- DefaultWordlist (id, int)
- Wordlists (Wordlist sequence, custom type needs import)
For now it only has a Path and an ID.
@daanbreur daanbreur mentioned this pull request May 11, 2021
d4rckh and others added 6 commits May 11, 2021 12:51
Removed the version number from the configfile.
Return Type *VafConfigStructure*
Contains *parseWordlist* and *parseVafConfig* function

parseWordlist <private>:
 - parameter type *JsonNode*
 - returns type *VafWordlist*

 parseVafConfig <public>:
 - parameter type *JsonNode*
 - returns type *VafConfigStructure*
@daanbreur daanbreur mentioned this pull request May 14, 2021
@d4rckh
Copy link
Owner Author

d4rckh commented May 15, 2021

We should make it so users don't need to provide the ID in the config file and only the path, like this:

{
 "wordlists": ["/wordlist1", "/wordlist2"]
}

@daanbreur
Copy link
Collaborator

Yes sir! Im working on it.
How do you select the default tho? just using a path?
If so the data would be:

{
  "DefaultWordlist": "/usr/wordlists/wordlist1.txt",
  "Wordlists": [ "/usr/wordlists/wordlist1.txt", "/usr/wordlists/wordlist2.txt", "/usr/wordlists/wordlist3.txt"]
}

@d4rckh
Copy link
Owner Author

d4rckh commented May 16, 2021

Yes sir! Im working on it.
How do you select the default tho? just using a path?
If so the data would be:

{
  "DefaultWordlist": "/usr/wordlists/wordlist1.txt",
  "Wordlists": [ "/usr/wordlists/wordlist1.txt", "/usr/wordlists/wordlist2.txt", "/usr/wordlists/wordlist3.txt"]
}

If there's only one element in the array, use that by default, otherwise ask for the number like 1-10

@daanbreur
Copy link
Collaborator

Guess we could do that. More like a number from 0 - length

@d4rckh
Copy link
Owner Author

d4rckh commented May 18, 2021

Guess we could do that. More like a number from 0 - length

Yup

@d4rckh d4rckh added enhancement New feature or request lowpriority labels Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lowpriority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants