Optionally prefer Body over viseme mesh during merging #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This handles the case where the avatar has a Body mesh and a separate viseme mesh that need to be merged together, and you want the merged output mesh to be called Body for MMD world compatibility.
|
I vaguely remember that I gave the viseme mesh priority because it had issues if it got merged into another mesh. Idk if I resolved those bugs or rely on the sorting. If the bugs don't exist anymore I don't see why I would even need an option for this and not just make it default behavior to merge into "Body". |
d4rkc0d3r
added a commit
that referenced
this pull request
Feb 16, 2024
|
There was indeed a bug that had to be fixed but it should now always merge into the mesh |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new setting handles the case where the avatar has a Body mesh and a separate viseme mesh that need to be merged together, and you want the merged output mesh to be called Body for MMD world compatibility.
It's a bit of an edge case, sure, but at least it's not much code to support.