Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Play Release #16

Closed
4 tasks done
d4rken opened this issue Jul 17, 2022 · 22 comments
Closed
4 tasks done

Google Play Release #16

d4rken opened this issue Jul 17, 2022 · 22 comments
Labels
enhancement New feature or request help/discussion wanted Extra attention is needed
Milestone

Comments

@d4rken
Copy link
Member

d4rken commented Jul 17, 2022

Do we? Do I? want this?

  • Graphic Assets
  • Screenshots
  • Description texts (could use the ones provided by @IzzySoft)
  • Can we automate releases via fastlane
@d4rken d4rken added enhancement New feature or request help/discussion wanted Extra attention is needed labels Jul 17, 2022
@dragonGod97677
Copy link
Contributor

dragonGod97677 commented Jul 17, 2022

I agree on description text and automate release

@IzzySoft
Copy link
Contributor

I'd strongly suggest including at least some screenshots with your Fastlane structure. People are much more like taking a closer look if they have some visual impression. Should you use Fastlane binaries to automate playstore release, the very same screenshots would be deployed there as well (including icon and featureGraphic, if you included them). So "one ring to rule them all" 😉

@d4rken
Copy link
Member Author

d4rken commented Jul 17, 2022

Of course, 2 screenshots are mandatory for gplay anyways 😉.

My fastlane skills are a bit rusty, ideally I would like to have this all very automated, more automated than my other apps, seeing as this a fresh project where things can go a bit wrong at the start 😁

Does fastlane support bundle signing + upload? 🤔
Last time I set fastlane app, we could all still use APKs 🥲

@IzzySoft
Copy link
Contributor

I've no idea about details on what the fastlane binaries can achieve, sorry – I work with the structures/metadata only. As bundles are now rather mandatory at Play (and devs have to hand over their private parts… ahem, signing keys – and thus should better use diffoscope¹ on the resulting APKs to make sure nothing was added), I'd expect it to support them, though.

My fastlane skills are a bit rusty

If you let me know and can cross-check once the structures are up, just send me a ping then. I'll have to do that anyway to tell my updater what to pick and how to handle it.


¹ F-Droid uses diffoscope for reproducible builds

@d4rken
Copy link
Member Author

d4rken commented Jul 17, 2022

As bundles are now rather mandatory at Play (and devs have to hand over their private parts… ahem, signing keys – and thus should better use diffoscope¹ on the resulting APKs to make sure nothing was added), I'd expect it to support them, though.

Yeah huge dislike from my end too. Actually rushed out a (yet to be released) alpha pre-deadline to still get grandfathered into the APK only option...

If you let me know and can cross-check once the structures are up, just send me a ping then. I'll have to do that anyway to tell my updater what to pick and how to handle it.

Will do ❤️

@IzzySoft
Copy link
Contributor

Hehe… heard of several devs applying for the "grandfathering option". A pity such a thing is necessary.

Looking forward to your ping then!

@d4rken d4rken added this to the v1.0.0 milestone Jul 27, 2022
@dragonGod97677
Copy link
Contributor

Ill provide screenshots when the permissions tab is sorted out.

@IzzySoft
Copy link
Contributor

Just let me know when they are there in Fastlane so I can tell my updater ow to handle them. Thanks!

@d4rken
Copy link
Member Author

d4rken commented Aug 2, 2022

@dragonGod97677 what do you think about the current permissions tab?

@dragonGod97677
Copy link
Contributor

@dragonGod97677 what do you think about the current permissions tab?

It's perfectly fine, I'll create a issue ticket when theres need a adjustment or something

@d4rken
Copy link
Member Author

d4rken commented Aug 22, 2022

@dragonGod97677 v0.9.0 currently building, I think we can take a few screenshots for Google Play now, what do you think?

@d4rken-org d4rken-org deleted a comment from dragonGod97677 Aug 23, 2022
@dragonGod97677
Copy link
Contributor

Permission Pilot Screenshots.zip
Here's the screenshots, I've done some oopies so.... i have to re-zip it and reupload it

d4rken added a commit that referenced this issue Aug 23, 2022
@d4rken
Copy link
Member Author

d4rken commented Aug 23, 2022

@d4rken
Copy link
Member Author

d4rken commented Aug 23, 2022

v1.0 is building

@d4rken d4rken closed this as completed Aug 23, 2022
@IzzySoft
Copy link
Contributor

IzzySoft commented Aug 23, 2022

@d4rken thanks, but the structure needs a little adjustment. Can you create a phoneScreenshots directory inside images/ and move the screenshots there (leaving icon & featureGraphic where they are)? See my Fastlane Cheat Sheet for details on the structure etc.

@d4rken
Copy link
Member Author

d4rken commented Aug 23, 2022

Like this? 8a2d406

@IzzySoft
Copy link
Contributor

Perfect, yes! I've already placed them here manually so you don't need to wait for the release to have them showing up – they will with the next sync today at around 6 pm UTC. Thanks a lot!

@IzzySoft
Copy link
Contributor

IzzySoft commented Aug 23, 2022

PS: as for https://github.com/d4rken-org/permission-pilot/tree/main/fastlane/metadata/android/en-US/changelogs – file names there should be <versionCode>.txt so they show up for the matching release 😉 If you let me know once those are there, I can enable them as well.

@d4rken
Copy link
Member Author

d4rken commented Aug 23, 2022

PS: as for https://github.com/d4rken-org/permission-pilot/tree/main/fastlane/metadata/android/en-US/changelogs – file names there should be <versionCode>.txt so they show up for the matching release wink If you let me know once those are there, I can enable them as well.

A default shows up by default for all other releases 😉
I won't be creating manual release notes for for most Google Play release.
Trying to keep overhead for updating the app low.
Have not found a good way to automate this.

@IzzySoft
Copy link
Contributor

OK, no prob – was just mentioning it as the corresponding directory was there. If you usually put a summary like on v0.9.0-RC0 I could instead add a changelog link to the app listing in general, so users can follow that. Just if you want, no pressure.

@d4rken
Copy link
Member Author

d4rken commented Aug 23, 2022

If you usually put a summary like on v0.9.0-RC0 I could instead add a changelog link to the app listing in general, so users can follow that. Just if you want, no pressure.

The changelogs on Github are generated, v0.9.0 looks nice because i did some features via PRs (required for the generation) instead of direct pushes to main.

I have not found a nice way to generate changelogs based on both PRs and commits.

If the app becomes more popular I will be a bit more tidy and do more things via PRs so changelogs should be nicer 😁.

I think a link to the Github releases would be great, they are the main "truth" for release notes. Google Play release notes will always only be a subset of that.

@IzzySoft
Copy link
Contributor

OK, added the link then. Might also serve as motivation 😛

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help/discussion wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants