New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extra build variants (GPlay?FOSS?) #4
Comments
Hey how are you BugSnag SDK is currently just in there as it's part of my starter project, can't actually be enabled by the user atm (backend isn't setup). Could maybe remove it. Depends a bit on how popular this becomes. Maybe a Build Variant for Google Play? With IAP and BugSnag, and a FOSS variant without? 🤔 |
already did (in my repo).
So it's not active … yet?
Then I of course can remove the Tracking AF (which looks a bit weird on an app like this 😉). If you promise to either remove or make it opt-in, I can override the automated flag straight away.
Sounds good to me! If you attach both APKs to releases, please let me know in advance so we can define which APK I can pick for my repo. And once you feel the app ready/mature enough for F-Droid.org, I can help with that as well. |
Yeah you can remove the tag, I'll make it opt-in or move it to an extra build variant all together before setting it up.
I'll keep the APKs on GitHub as is, and if there is a Google Play variant it will have to be APK bundles anyways and that's probably uninteresting to everyone but Google Play 😓
Awesome, give me a few more days 😉 |
Great, thanks! So the (only) APK attached here will be the one without Bugsnag then?
All the time you need. Your app is already available via my repo, so no need to hurry. Better start at F-Droid.org with something "mature" – "first impression" and all that 😉 PS: |
Created another build flavor, kept bugsnag in both. Relevant code for opt-in/out: I added gplay billing dependency but it should only be included in the gplay buid. For the foss build it just links to GitHub. There should still only be one APK attached to releases, but the name has slightly changed, e.g.: |
Sounds fine with me – so I can keep the
Again fine, thanks! TBH I do not care too much what you put into the Play build¹ as long as it does not hit the Foss build.
The name only matters if there are multiple APKs attached – because then I need to take care the updater does not pick the wrong one. So thanks a lot – that's a very good solution for all involved! ¹ well, to a degree: would you add a bunch of invasive trackers, users might get curious whether they could really trust the Foss one or if something sneaked in there, too 🤣 |
PS: You forgot to attach the APK to the latest release 😱 |
Ahhh thanks. b10c120#diff-1a01768048176e9aae1daf1472171fd9134e697c1ed988f40d12370a483cd3ecR64 |
Gladly – and thanks to you! I just triggered the updater manually – fetched the update fine, so all seems set. Just an icon is not there (ah, yes, issue is already open for that I see). As for metadata in general: would you like a PR shipping you initial fastlane structures? I could offer to send you what I've set up with my repo currently – so you could take over from there and adjust whenever needed. And build upon – e.g. adding screenshots, icon, featureGraphic 😉 |
FYI The idea is/was to make it easier to let people get involved as orgs have more fine grained permission control than repositories on personal accounts. |
No build services here – and yes, redirects should work (at least for a while). If you can provide me a list of packageIds I should check, I can take care to update the URLs so everything is straight again. Speaking of permissions and the current GH/MS controversy: should you move to Codeberg, just let me know. There are no forwards from here to there – but my updater of course can deal with Codeberg just fine (I've moved almost all of my repos there years ago and archived them here). And yes, you have orgs there as well as CI and pages 😉 |
What packageIds do you mean? Currently I just moved If this is everything i hope it to be, I might move other apps of mine that are still on Google Play there (e.g. https://github.com/d4rken/bluemusic).
Seen it and I respect the effort, but so far MS has not made any moved that I found too concerning (except buying the whole thing). Quite happy with GitHub still 😄. Not sure I would go with Codeberg over Gitlab though 🤔 |
Quick check: I can find
Codeberg is hosted in DE and is driven by a community (Codeberg e.V.) – both strong reasons for me. They have very good support – another strong argument. Also, migration works like a breeze. That I also have contact to some of the team is a bonus to me – but I very much like how it works. Well, just saying 😉 |
Is there a better crash tracking tool that wouldn't get tagged as |
Afraid not. It needs to be marked a false positive when it's opt-in. But be welcome to check potential candidates for "better otherwise" 😉 |
PS: your Readme has an PlayStore link that leads to a 404 – but no link to the alreay working representation in my repo. Mind to fix that? You know ehre to find a badge for that, right? 😉 And while on it: you could move that app banner to |
Google has rejected the APK, need to submit it for review again.
I'm a bit confused on the different between yoru repos and F-Droid, could you elaborate?
Good point, will do. |
Ah, the usual G-hell… 😢
Basically this. Plus that F-Droid's inclusion criteria are stricter. Thanks for moving icon+featureGraphic to Fastlane – adjusted the config for my updater to check them on updates. |
The badge doesn't fit nicely into the readme's current style, (or we get a matching badge for google play and github too) but I'm open to adding a bullet point to the download section. Something like
What happens when it is clicked? The F-droid app on the users phone opens? |
Look more closely – and pick "the other one" which fits perfectly in the row between "release" and "downloads" 😉 Details on how to use that one are here. Further down you could then place a text link next to the others (or use the corresponding badges there for each of them: there's one for Google, and another for Github available, so the 3 would look similar in style to each other). (I've just picked them from different locations – you may wish to copy them and keep them in your repo so they do not disappear)
If you link it directly to the app details page, it will open in a browser. But you can use a slightly different URL: using |
Yeah but that doesn't fit there, it's more for "look but not touch". The small badges do not present themselves to users as a primary way to download the app, especially when having 3 badges for 3 download places there 🤔 |
That looks fine! And even gives additional details. Cool! |
* Create ic_access_notification_policy_24.xml Allows apps to read all your notifications, including personal information (such as contact names and text of messages you receive), snooze or dismiss notifications or trigger action buttons they contain (such as answer phone calls, delete your sms/ email, etc) and turn Do Not Disturb (DND) ON or OFF or change related settings. * Update ic_access_notification_policy_24.xml Allows the app to turn Do Not Disturb (DND) ON or OFF and change related settings. * Create ic_access_notifications_24.xml * Create ic_schedule_exact_alarm_24_xml * Update APerm.kt * Update strings.xml * Rename ic_schedule_exact_alarm_24_xml to ic_schedule_exact_alarm_24.xml * Update APerm.kt (#4) * Update strings.xml * Update APerm.kt * Update APerm.kt * Update APerm.kt * Update APerm.kt * Update APerm.kt * Update strings.xml * Update APerm.kt * Update strings.xml * Update APerm.kt * Update strings.xml * Update APerm.kt * Update strings.xml * Update APerm.kt * Create ic_access_to_media_only_24.xml
Hi @d4rken, I just wonder as my library scanner reports Bugsnag: is it opt-in, so I can override the
Tracking
marker for your app?The text was updated successfully, but these errors were encountered: