Switch to interactive root shell

[SuperSandro2000]

SD maid would run a bit faster if you would use an interactive root shell and not doing 7 root requests to launch app control.

[d4rken]

What do you mean by "launch app control"?

[SuperSandro2000]

When I simply launch the app control in SD Maid the app does a total of 7 root requests to magisk. Maybe decrease them cause each su request is an intensive operation.

[d4rken]

Is it only the first time on a cold start? Some calls may come from SD Maids initial setup routines. Reusing shells across unrelated modules is possible but makes multitasking more bug prone. I'll have to look into each call. Sandro Jäckel <notifications@github.com> schrieb am So., 23. Sep. 2018, 12:32:

…

When I simply launch the app control in SD Maid the app does a total of 7 root requests to magisk. Maybe decrease them cause each su request is an intensive operation. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#2018 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABX1_SUc_LCDdVcixj1lV9Hmm4emFZGkks5ud2NFgaJpZM4W1cpo> .

[SuperSandro2000]

Cold start does 7 root requests and reload does two. I don't expect to bring it down to one but maybe 2 or 3 if it is easily achievable.

[d4rken]

Base setup

1. RootContext, shell launch is part of su test
2. Binary setup, shell is launched once for all applet tests to know if they work with root
3. Storage setup, one shell for all storage modules to get their data
4. Storage setup, private data module starts another shell ❓

AppControl

5. Loading process data, e.g. running apps
6. Perform a check for hidden apps when loading app data, check for instant apps
7. Another check for hidden apps ❓

[d4rken]

3 is a basic command shell, but 4 is a filereader that internally uses a root shell too.

7 is the actual loading of installed apps, 6 is actually part of 5, because to load running apps we also need to know the installed apps.

[d4rken]

I think I can remove 4, by reusing 3's shell.

I'll have to look more into whether we can do 7 first, then reuse it in 5 and 6.

I've started on removing 4, but it's more complicated than I thought. Too exhausted for that now I want to release this beta. Pushing this to the next update 😅.

[d4rken]

Eliminated 4 by reusing 3's shell.

Also eliminated 6 by ensuring 5 runs after 7. With 5 will reuse the cached data from step 7, so no extra shell will be launched.

7 -> 5 👍

The rest can't easily be eliminated without breaking seperation of concerns between the different parts of SD Maid. It would also get us into concurrency hell when multiple tools are running in parallel.