Skip to content
This repository has been archived by the owner on Jan 15, 2024. It is now read-only.

Fixes #109: Check signature for hardcoded match to GitHub build signature #144

Merged
merged 2 commits into from
Sep 4, 2017
Merged

Fixes #109: Check signature for hardcoded match to GitHub build signature #144

merged 2 commits into from
Sep 4, 2017

Conversation

bobheadxi
Copy link
Collaborator

@bobheadxi bobheadxi commented Sep 4, 2017

Issues

#109: Notify F-Droid users that download link in Update dialogue won't work for them, relevant comment here:

This can be solved by comparing the signature of the apk that is installed (which can be accessed through the packagemanager) and comparing it with the signature of the github build apks (which doesn't change and could be hardcoded)

Changes

When showing changelog, check for a signature match and add a line notifying users that using the download link will require a reinstall

Isn't the point of the signature that it should be hidden though?

@d4rken
Copy link
Member

d4rken commented Sep 4, 2017

Isn't the point of the signature that it should be hidden though?

What do you mean?

Copy link
Member

@d4rken d4rken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bobheadxi
Copy link
Collaborator Author

bobheadxi commented Sep 4, 2017

Never mind I get it now 👍

@bobheadxi bobheadxi merged commit ae9d0c5 into d4rken-org:dev Sep 4, 2017
@bobheadxi bobheadxi deleted the pr/check-build-origin branch September 5, 2017 04:33
bobheadxi added a commit that referenced this pull request Sep 6, 2017
…ture (#144)

* Displays a notice in Changelog if user installed app from another source
bobheadxi added a commit that referenced this pull request Sep 6, 2017
bobheadxi added a commit that referenced this pull request Sep 6, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants