Build fails #104
Comments
|
Why build on that commit? It is several commits behind, have you tried building 6996d5e? |
|
It is what is tagged as v0.7.0 and for F-Droid we are building on tags... |
|
Oh my bad, I misunderstood - might have to wait for a comment from @d4rken |
|
We are building against Someone either has to to hardcode an older snapshot in the gradle file, or fix the issue. |
|
@bobheadxi Can you make a new release and add a new tag or move the existing one to that commit? |
|
Best if @d4rken does it when he has time, not sure what the process is, might be better if release as v0.7.1? |
Only the last step is something I need to do because I have the signing key used for the previous github versions, for F-Droid that's not necessary though. |
|
Thinking about it, it might have been better to first merge then tag as the appstore app uses the tags to determine whether an update is available. That way we don't signal a new update before noticing an issue with the final build (i.e. travis is still testing the PR atm). Hm actually we can do the tag, just not create a release for it on github, because that's what the app checks, right? Not sure what the app does when there is a new release, but no Anyways, for F-Droid it should suffice. |
|
I believe the app waits for a release, and since v0.7.0 is still the "Latest Release" the tag in its current state shouldn't do anything Without an apk attached, the app might just attempt to download the source code - should probably add a check to the app to check for that before indicating a release I've put up a draft with an apk build attached, will that do or does it have to be done by you? Also unsure if I'm the only one who can see my drafts |
Yeah I think that's the way it's implemented, at least I hope so 😁 .
Yeah though the draft approach seems sufficient.
Everyone can see the drafts, but the attached APK won't work because it's not signed with the same signature key as the version everyone has installed, so they can't update it. They will get an error. To install it the previous version has to be uninstalled. That's Androids security mechanism so to prevent malicious updates. It guarantees that the APK someone installs is generated from a trusted source, i.e. the same source that build the previous version (or at least had access to the same key). Unless you created your own signing key the current apk is signed with a debug key, but in either case users won't be able to update with it. I'll build an APK later and attach it to your draft. |
|
F-Droid has it's own signing key which is why our APKs are not compatible with APKs build by F-Droid. Compatible meaning they can't update over each other. |
|
Ah I see
Thanks!
Does this mean when people using the FDroid build attempt to download an update via the "Update Available" dialogue built into the app they will run into problems? |
Yes, the Android installer will throw an error during the update attempt. If someone wants to do a PR 😉 : This can be solved by comparing the signature of the apk that is installed (which can be accessed through the packagemanager) and comparing it with the signature of the github build apks (which doesn't change and could be hardcoded). If it doesn't match, don't show an update dialog or show some other kind of information. |
|
Seems fairly important usability wise, opened up an issue (#109) for it and will get around to it :) thanks! |
|
Yeah could be quite annoying, though I would guess that regular F-Droid users are fairly familiar with the issue as it also affects apps that are available from GPlay+FDroid. |
|
@d4rken How exactly does this work?
|
|
By using something like You could detect whether the apk is from github or froid by checking it for a specific signature. The apk from github will have my signature (from the certificate file on my hdd), while the apk from fdroid will have their signature. |
Returns So our SHA1 certificate fingerprint is This code reads the fingerprint for an any installed package and also returns the SHA finger print: For the release apk of this app it would return a list with a single entry, namely the above SHA1 fingerprint. For the F-Droid APK it would be a different fingerprint. |
Building on commit c70a58d
The text was updated successfully, but these errors were encountered: