-
Notifications
You must be signed in to change notification settings - Fork 743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scheduler crashes if setup was not done #278
Comments
darken, might I suggest executing the setup on the first SD Maid run itself? My reasoning for this is that if you add some other feature later that also needs the setup to be complete before functioning, you'll know it's already done and won't need to add or rewrite code then. |
I don't like it though if when opening the app the first thing the user sees is some kind of loading and then a popup without having done anything. It also means the causality isn't clear, if the user clicks an action and then it happens the causality is more obvious. I'll make a specific setup check and sprinkle it across a few things (for now). |
Matthias, |
It's not only about QuickAccess, you could have been on another page and then inserted an sdcard and reopened SD Maid. Furthermore it's not just about external sdcards, but also root check and since 6.0 storage permission. |
True. |
@Trasd Which helps me make the decisions :). |
Sorry, it took me a bit to realize these weren't direct emails from you, but were posting directly to (and coming from) the new issues list! When we email, I use my gmail address - that should have been a dead giveaway. |
If the scheduler triggers and the setup was not done, SD Maid tries to show the setup dialog but crashes.
We could either force the setup when opening the scheduler view or show a notification that the scheduler skipped because the setup was not done.
The text was updated successfully, but these errors were encountered: