Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle panics by deferring recover as an error #345

Merged
merged 3 commits into from
Nov 13, 2021
Merged

Conversation

ganehag
Copy link
Contributor

@ganehag ganehag commented Sep 2, 2021

As described in issue #344. I've added a defer statement to handle panics.

script.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@geseq geseq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and looks like a decent addition as well. @d5?

@d5 d5 merged commit a7666f0 into d5:master Nov 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants