Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sign-conversion warnings #111

Closed
laoshaw opened this issue Jul 8, 2022 · 3 comments
Closed

sign-conversion warnings #111

laoshaw opened this issue Jul 8, 2022 · 3 comments
Assignees

Comments

@laoshaw
Copy link

laoshaw commented Jul 8, 2022

would be nice to eliminate warning like this:

rapidcsv.h:1062:32: warning: conversion to ‘std::__cxx1998::vector<std::__debug::vector<std::__cxx11::basic_string<char> >, std::allocator<std::__debug::vector<std::__cxx11::basic_string<char> > > >::size_type’ {aka ‘long unsigned int’} from ‘ssize_t’ {aka ‘long int’} may change the sign of the result [-Wsign-conversion]

there are a lot of them.

@d99kris d99kris self-assigned this Jul 9, 2022
@d99kris
Copy link
Owner

d99kris commented Jul 19, 2022

Thanks for pointing this out, it makes sense. Will prepare a fix.

@d99kris
Copy link
Owner

d99kris commented Jul 24, 2022

A fix for this is under review in pull request #112 - will update this issue once it's integrated to master branch.

@d99kris
Copy link
Owner

d99kris commented Jul 24, 2022

The sign conversion warnings should be fixed in master branch now, with above commit. Please let me know if you still encounter any warnings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants