fixes #111 - fix sign conversion warnings (#112)

* fix sign conversion warnings * update doc * review updates 1
d99kris · Jul 24, 2022 · ce6b9af · ce6b9af
1 parent 7d38da0
commit ce6b9af
Show file tree

Hide file tree

Showing 5 changed files with 133 additions and 108 deletions.
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -11,7 +11,8 @@ if(MSVC)
 else()
   set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -g -Wall -Wextra -Wpedantic -Wshadow -Wpointer-arith \
                        -Wcast-qual -Wno-missing-braces -Wswitch-default -Wcast-align \
-                       -Wunreachable-code -Wundef -Wuninitialized -Wold-style-cast")
+                       -Wunreachable-code -Wundef -Wuninitialized -Wold-style-cast \
+                       -Wsign-conversion")
 endif()
 
 # Build type

diff --git a/doc/README.md b/doc/README.md
@@ -1,8 +1,8 @@
 # API Documentation
+ - [class rapidcsv::Converter< T >](rapidcsv_Converter.md)
+ - [class rapidcsv::ConverterParams](rapidcsv_ConverterParams.md)
  - [class rapidcsv::Document](rapidcsv_Document.md)
  - [class rapidcsv::LabelParams](rapidcsv_LabelParams.md)
- - [class rapidcsv::SeparatorParams](rapidcsv_SeparatorParams.md)
- - [class rapidcsv::ConverterParams](rapidcsv_ConverterParams.md)
  - [class rapidcsv::LineReaderParams](rapidcsv_LineReaderParams.md)
+ - [class rapidcsv::SeparatorParams](rapidcsv_SeparatorParams.md)
  - [class rapidcsv::no_converter](rapidcsv_no_converter.md)
- - [class rapidcsv::Converter< T >](rapidcsv_Converter.md)
diff --git a/doc/rapidcsv_Document.md b/doc/rapidcsv_Document.md
@@ -233,7 +233,7 @@ Get column index by name.
 ---
 
 ```c++
-std::string GetColumnName (const ssize_t pColumnIdx)
+std::string GetColumnName (const size_t pColumnIdx)
 ```
 Get column name. 
 
@@ -333,7 +333,7 @@ Get row index by name.
 ---
 
 ```c++
-std::string GetRowName (const ssize_t pRowIdx)
+std::string GetRowName (const size_t pRowIdx)
 ```
 Get row name. 
 

diff --git a/doc/rapidcsv_LabelParams.md b/doc/rapidcsv_LabelParams.md
@@ -5,7 +5,7 @@ Datastructure holding parameters controlling which row and column should be trea
 ---
 
 ```c++
-LabelParams (const int pColumnNameIdx = 0, const int pRowNameIdx = \-1)
+LabelParams (const ssize_t pColumnNameIdx = 0, const ssize_t pRowNameIdx = -1)
 ```
 Constructor.