Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bene Trigger Output Only Updates Once Per Sequencer Cycle #61

Open
DJGlitch816 opened this issue Oct 5, 2022 · 1 comment
Open

Bene Trigger Output Only Updates Once Per Sequencer Cycle #61

DJGlitch816 opened this issue Oct 5, 2022 · 1 comment

Comments

@DJGlitch816
Copy link
Contributor

If Bene were to be halfway through a sequence (say it's currently playing step 6), and if I were to turn the gate/trigger out of step 11 on, the trigger output won't do anything on step 11 until the sequencer finishes it's cycle and plays through again. The output is updated for the gate out and the voltage out, though.

@DJGlitch816
Copy link
Contributor Author

Looking through the source code, I was able to fix the update issue by moving the trigger generate function.

if(gates[x_position][y_position])
{
  trig_out[x_position][y_position].trigger(1e-3);
}

I moved this from the if(step) functions down by the gate and voltage outputs and it sort of fixed it. However, it outputs repeated triggers for the entire time the function yields true, currently attempting to fix this by implementing a schmitt trigger with isHigh() to create triggers from the condition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant