Skip to content

Commit

Permalink
nfs41: fix condition when NFS4ERR_GRACE returned on OPEN
Browse files Browse the repository at this point in the history
Motivation:
According to rfc5661 server sMUST return NFS4ERR_GRACE if:

  - server in the grace period (rfc5661#section-18.16.3)
  - client did not issued reclaim_complete(rfc5661#section-18.51.3)

Modification:
fix the condition when NFS4ERR_GRACE is returned.

Result:
better spec compliance.

Acked-by: Albert Rossi
Target: master
  • Loading branch information
kofemann committed Nov 2, 2018
1 parent 7fc7a59 commit 863bd66
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion core/src/main/java/org/dcache/nfs/v4/OperationOPEN.java
Expand Up @@ -94,7 +94,7 @@ public void process(CompoundContext context, nfs_resop4 result) throws ChimeraNF

case open_claim_type4.CLAIM_NULL:

if (client.needReclaim() && context.getStateHandler().isGracePeriod()) {
if (client.needReclaim() || context.getStateHandler().isGracePeriod()) {
throw new GraceException();
}

Expand Down

0 comments on commit 863bd66

Please sign in to comment.