Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deps #7

Merged
merged 6 commits into from
Apr 12, 2023
Merged

Update deps #7

merged 6 commits into from
Apr 12, 2023

Conversation

vbkaisetsu
Copy link
Member

No description provided.

@vbkaisetsu vbkaisetsu marked this pull request as draft April 12, 2023 01:05
@vbkaisetsu vbkaisetsu marked this pull request as ready for review April 12, 2023 01:09
@vbkaisetsu vbkaisetsu enabled auto-merge (squash) April 12, 2023 01:41
Copy link
Member

@kampersanda kampersanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried this tool following the instructions in the README. I thought users were going to be confused when loading the downloaded zstd model (since the API doc just says A byte sequence of the dictionary.)

How about placing notes in the same manner as Notes for Vibrato APIs.

@vbkaisetsu
Copy link
Member Author

@kampersanda Updated readme

@vbkaisetsu vbkaisetsu merged commit 283e32c into main Apr 12, 2023
20 checks passed
@vbkaisetsu vbkaisetsu deleted the vbkaisetsu-patch-1 branch April 12, 2023 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants