Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a builder for system dictionary #74

Merged
merged 4 commits into from
Oct 17, 2022
Merged

Add a builder for system dictionary #74

merged 4 commits into from
Oct 17, 2022

Conversation

kampersanda
Copy link
Member

This PR addresses the issue #52.

I'll plan to solve the issue with two steps:

  1. Add a builder structure for Dictionary.
  2. Add builder structures for submodules under dictionary.

This PR is the first step, which adds a struct SystemDictionaryBuilder for building Dictionary from system entries and moves functions user_lexicon_from_reader and mapping_from_iter under the module dictionary.

@kampersanda kampersanda marked this pull request as draft October 17, 2022 06:41
@kampersanda kampersanda marked this pull request as ready for review October 17, 2022 08:21
@kampersanda @vbkaisetsu
Update vibrato/src/dictionary.rs
5207d4e 
Co-authored-by: Koichi Akabe <vbkaisetsu@gmail.com>
@kampersanda kampersanda merged commit 332798c into main Oct 17, 2022
@kampersanda kampersanda deleted the reconfig-builder branch October 17, 2022 09:43
@kampersanda kampersanda mentioned this pull request Oct 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbkaisetsu vbkaisetsu vbkaisetsu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kampersanda @vbkaisetsu