Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggestion: skip quotation marks & apostrophes #3

Closed
cometkim opened this issue Nov 30, 2021 · 2 comments · Fixed by #4
Closed

Suggestion: skip quotation marks & apostrophes #3

cometkim opened this issue Nov 30, 2021 · 2 comments · Fixed by #4

Comments

@cometkim
Copy link
Member

cometkim commented Nov 30, 2021 •
edited
Loading

e.g.

  • Someone said "help", but ignored -> someone-said-help-but-ignored
  • Parse, don’t validate -> parse-dont-validate

Note this will be BREAKING change
@cometkim
Copy link
Member Author

cc @plastic041

@plastic041
Copy link

I agree to change.

@cometkim cometkim changed the title Suggestion: treat quotation & apostrophe as skip Suggestion: skip quotation marks & apostrophes Dec 2, 2021
cometkim added a commit to cometkim/cjk-slug that referenced this issue Dec 2, 2021
@cometkim
strip quotation marks & apostrophe
da8191a 
Resolves daangn#3
@cometkim cometkim mentioned this issue Dec 2, 2021
Merged
cometkim added a commit that referenced this issue Dec 2, 2021
@cometkim
strip quotation marks & apostrophe (#4)
4f6e3f3 
Resolves #3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

strip quotation marks & apostrophe cometkim/cjk-slug
2 participants
@cometkim @plastic041