Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image overlapping tabs #471

Closed
julian10m opened this issue Mar 28, 2019 · 4 comments
Closed

Image overlapping tabs #471

julian10m opened this issue Mar 28, 2019 · 4 comments

Comments

@julian10m
Copy link

Hi Dean, thanks a lot for the theme.

I think there is an issue with the tabs ("About Me", "Projects", etc) and the image. More precisely, I am referring to the moment when the display switches from a to b:

a) displaying all the tabs,
b) displaying just the button that gathers all the options (more for mobile case).

In my case, I added a 4th tab. What I see that happens is that, when I decrease the width of browser, there are intermediate states between a) and b) where the first tab (the one more to the left) finishes being almost/completely hidden beneath the image.

I also noticed that my name, of round 18 characters, finishes being displayed "extremely" close to the left border, which makes it a little bit unpleasant to the eye. While for Google Chrome this does not happen at all, the issue is revealed appears when using Mozilla.

Well, that's all. Minor things, but they catch my attention and I have no idea where to touch to solve it myself.

Have a nice day,

Best,
Julian

@daattali
Copy link
Owner

Hi Julian,
Thanks for your concern. Unfortunately design issues like these are impossible to prevent in a generic way. For a single website you can get the layout to work the exact way you want it to by modifying the CSS to be pixel perfect, but in a generic template that supports any browser width and any arbitrary number of tabs, you're bound to run into these sort of issues. My best suggestion is either to remove the avatar image altogether, or you can just move it down a bit with CSS

@cryptic0
Copy link

I was just about to open a new issue with this exact comment. Now I will look into CSS. My problem has been that on pages that don't have a lot of content, there is no way to scroll down to make the avatar image dissolve as it normally does.

@cryptic0
Copy link

main.css: L196:200

I made the following changes:

@media only screen and (min-width: 768px) {
  .navbar-custom .avatar-container {
    width: 75px;
    margin-top: -10px;
  }

@daattali
Copy link
Owner

daattali commented Jun 7, 2019

Glad you sorted it out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants