Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

giscus support #886

Closed
patgarz opened this issue Oct 6, 2021 · 4 comments · Fixed by #888
Closed

giscus support #886

patgarz opened this issue Oct 6, 2021 · 4 comments · Fixed by #888

Comments

@patgarz
Copy link
Contributor

patgarz commented Oct 6, 2021

I'm reaching the finishing stages of adding giscus comments support for my Beautiful Jekyll site. If you're not familiar, giscus is what I would consider the "spiritual successor" to utterances as it uses GitHub Discussions rather than GitHub Issues for its comments.

Do you have any interest in me putting together a PR to add that functionality? Setup is almost identical to utterances so I don't think it adds much, if any, complexity (apart from a slightly longer config file).

@daattali
Copy link
Owner

daattali commented Oct 6, 2021

Thanks for reaching out! Would this only involve adding a fee more fields to the config file and no other changes?

@patgarz
Copy link
Contributor Author

patgarz commented Oct 6, 2021

To any consumer, yes. For anyone wanting to dive into the site code, they'll also find the giscus-comment.html included in _includes and a reference in comments.html (nearly identical to utterances).

I'll go ahead and put together the PR and link it here so you can see the exact diff - should be able to do that after I'm off work this evening.

@daattali
Copy link
Owner

daattali commented Oct 6, 2021

OK that sounds like a small enough change. Please do go ahead, and make sure to also update the CHANGELOG and README accordingly

@daattali
Copy link
Owner

Closign the issue, as it's already in a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants