Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packages using shinyjs can't deploy to shinyapps.io without explicitly importing V8 package #20

Closed
daattali opened this issue Jul 12, 2015 · 4 comments

Comments

@daattali
Copy link
Owner

This issue was reported to me by @alexwhan via a pullrequest. I believe this is more of a problem with shinyapps than with my package, and the shinyapps team kind of agreed, but I'm not sure if they'll fix it. If it doesn't get resolved on shinyapps end, then I should accept the PR, or at least make a comment about it in the documentation.

related:

@daattali
Copy link
Owner Author

I've updated the documentation of extendShinyjs to reflect this problem and there is an an open issue on rstudio/shinyapps github repo for this problem. I likely will not "fix" this on my end

@jgabry
Copy link

jgabry commented Aug 3, 2015

Is this only an issue if using extendShinyjs or is this a problem even if only using functions like onclick, toggle, etc? Thanks!

@daattali
Copy link
Owner Author

daattali commented Aug 3, 2015

This is only an issue when using extendShinyjs, as that is the only function that uses the V8 package. That's exactly the reason I don't want to make my package explicitly depend on V8, because the vast majority of users will never use extendShinyjs and I don't want to force an extra package installation on them.

@jgabry
Copy link

jgabry commented Aug 3, 2015

Ok thanks, that makes sense.

And thanks for the great package!

On Monday, August 3, 2015, Dean Attali notifications@github.com wrote:

This is only an issue when using extendShinyjs, as that is the only
function that uses the V8 package. That's exactly the reason I don't want
to make my package explicitly depend on V8, because the vast majority of
uses will never use extendShinyjs and I don't want to force an extra
package installation on them.


Reply to this email directly or view it on GitHub
#20 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants